Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tag_dispatch back to tag_invoke #5600

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Rename tag_dispatch back to tag_invoke #5600

merged 1 commit into from
Oct 21, 2021

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Oct 7, 2021

Fixes #5570.

@msimberg msimberg added category: utilities category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals labels Oct 7, 2021
@msimberg msimberg added this to the 1.8.0 milestone Oct 7, 2021
hkaiser
hkaiser previously approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! LGTM. Do you plan to move the priority and fallback facilities to namespace detail in this PR or in a separate one?

@msimberg
Copy link
Contributor Author

msimberg commented Oct 7, 2021

Thanks for looking into this! LGTM. Do you plan to move the priority and fallback facilities to namespace detail in this PR or in a separate one?

I might as well do it in one go.

@msimberg
Copy link
Contributor Author

This should now be ready. I've also moved the tag priority/fallback helper header files to hpx/functional/detail.

hkaiser
hkaiser approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect you would rename the fallback/priority dispatch utilities as well. But sure, let's go with that. Thanks!

aurianer
aurianer approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg
Copy link
Contributor Author

I didn't expect you would rename the fallback/priority dispatch utilities as well. But sure, let's go with that. Thanks!

I figured it makes sense if we still call the main facility tag_invoke, plus it's now in detail so we can rename it back and forth as much as we want ;)

@msimberg msimberg merged commit e0d916b into STEllAR-GROUP:master Oct 21, 2021
@msimberg msimberg deleted the tag-dispatch-rename-invoke branch October 21, 2021 08:01
@albestro albestro mentioned this pull request Nov 23, 2021
Merged
7 tasks
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Nov 23, 2021
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
4c37511
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Nov 23, 2021
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
d68f92c
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 1, 2021
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
dfe0305
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 6, 2021
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
9a03917
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 9, 2021
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
440722e
msimberg pushed a commit to msimberg/DLA-Future that referenced this pull request Jan 21, 2022
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
e193f3b
msimberg pushed a commit to eth-cscs/DLA-Future that referenced this pull request Jan 24, 2022
@albestro
revert compatibility layer according to STEllAR-GROUP/hpx#5600
2cf815d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@hkaiser hkaiser hkaiser approved these changes

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals category: utilities
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Rename tag_dispatch to tag_invoke
3 participants
@msimberg @hkaiser @aurianer