Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Context2NameTest#testContext2Name seems to be failing #876

Closed
danglotb opened this issue Sep 17, 2019 · 2 comments
Closed

TEST: Context2NameTest#testContext2Name seems to be failing #876

danglotb opened this issue Sep 17, 2019 · 2 comments
Labels
bug high priority This issue has the highest priority and should be fixed as soon as possible prettifier This issue is related to the module DSpot - Prettifier testing

Comments

@danglotb
Copy link
Member

danglotb commented Sep 17, 2019 •
edited
Loading

Hello,

I just found out that the test in dspot-prettifier Context2NameTest#testContext2Name seems to be failing.

In the shell script, the installation of required dependencies was after the mvn test goal. So the build the tests were not passing but the build was because the installation went fine.

In #875, I swapped the order and @Ignore the test method.

@jianguda could you have a look at this? Thank you.
@danglotb danglotb added bug high priority This issue has the highest priority and should be fixed as soon as possible prettifier This issue is related to the module DSpot - Prettifier testing labels Sep 17, 2019
@jianguda
Copy link
Contributor

jianguda commented Oct 9, 2019

Hey @danglotb sorry for missing your message, I will check this later this week.

@jianguda
Copy link
Contributor

Hey @danglotb
I checked and found it is not because of Context2NameTest
Here is my CI result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high priority This issue has the highest priority and should be fixed as soon as possible prettifier This issue is related to the module DSpot - Prettifier testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danglotb @jianguda