Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing required extra Maven configuration to DSpot #757

Open
jesus-gorronogoitia opened this issue Apr 9, 2019 · 2 comments
Open

Comments

@jesus-gorronogoitia
Copy link
Collaborator

Characteristics

  • Issue Type: feature
  • Reproducibility: always
  • Severity: feature
  • Tool/Service/Component: DSpot
  • Execution Environment: Linux
  • Reporter: Jesús Gorroñogoitia [email protected]

Description

Atos UC Supersede IF module needs to be build with Maven by accessing some repositories whose access is restricted by credentials. As these credentials cannot be included in the pom.xml they are encoded in a settings.xml that is passed to Maven using its -s flag.
The point is that this configuration (-s settings.xml) is not passed to the forked Maven executions requested by DSpot, and hence failing as the dependencies are not resolved), so I wonder it could be possible to improve DSpot parameterization to incorporate another DSpot flag to pass additional Maven configuration that should be passed to any internal (to DSpot) Maven invocation.

Steps to reproduce

Properties file
Command Line / Options

Other files and URLs

Relationships

Help on issue template

Preview to follow the link or open file .github/ISSUE_DOC.md

@danglotb
Copy link
Member

danglotb commented Apr 9, 2019

Hi @jesus-gorronogoitia

Thank you for the issue.

A way to do this is to extend the usage of the property maven.pre.goals.

I'll open a pull request ASAP with this new feature.

@danglotb danglotb self-assigned this Apr 9, 2019
@jesus-gorronogoitia
Copy link
Collaborator Author

Hi @danglotb
I've been able to fix this issue in our Jenkins CI by setting correctly the default settings.xml. Nonetheless, if you don't mind, I prefer to keep it open, with low priority, in case you eventually have time to implemented, because I think this feature is important to pass parameters to Maven if needed when DSpot is executing the forked Maven executions. Thanks a lot.

@danglotb danglotb removed their assignment Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants