A11y: fixed aria-current for entry titles

[akash07k]

Fixed aria-current for entry titles.
Previously the aria-current was getting applied to the whole entry.

[akash07k]

Oh, ok, it's great then, but those keys are not working and even screen reader is not announcing them. seems that I'll have to look at it as well then. :-(

…

On 10/1/19, Jan Tojnar ***@***.***> wrote: jtojnar commented on this pull request. > @@ -176,13 +176,13 @@ selfoss.ui = { entrySelect: function(entry) { if (selfoss.ui.selectedEntry !== null) { selfoss.ui.selectedEntry.removeClass('selected'); - selfoss.ui.selectedEntry.attr('aria-current', 'false'); + $('.entry-title > .entry-title-link', entry).attr('aria-current', 'false'); > Now, even though I'm collapsing the entry, Screen reader is still > announcing 'current' for the entry. That is correct behaviour. The last entry you interacted with will be selected (visually, there is a darker border around it). Entry being selected means you can use selfoss keyboard shorcuts to expand it again (<kbd>o</kbd>), open the link (<kbd>v</kbd>), or switch to a previous or next entry (<kbd>j</kbd> and <kbd>k</kbd>, or arrow keys). -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #1141 (comment)

[jtojnar]

Hmm, I thought I tested that edge case but apparently not. Will push a fix shortly.

[jtojnar]

Is this good to go?

[jtojnar]

Rebased onto master for clean git history.

[akash07k]

Is this good to go?

Yes, it is fine now, but still the keys are not being identified by the screen readers, I feel that I'll have to look deep down into it and will have to manually expose the commands by some methods. But as of now, we can leave it aside for future.

[jtojnar]

Yeah, they are not very visible for sighted users either. User will either already know the keyboard shortcuts from Google Reader, which we inherited, or read about them on the web page. We should add a help overlay when pressing h.

Not sure how to expose the shortcuts to visually impaired users other than adding buttons for every action there is a shortcut for, and putting aria-keyshortcuts to that. But I am not sure how usable it would be with the 22 shortcuts selfoss currently supports.

[akash07k]

I think that something is better than nothing. Although the user will have to remember all the shortcuts, but eventually they will be able to become habitual to these shortcuts. using aria-keyshortcuts is a good idea indeed. But implementing overlay will be tricky I feel

…

On 10/3/19, Jan Tojnar ***@***.***> wrote: Yeah, they are not very visible for sighted users either. User will either already know the keyboard shortcuts from Google Reader, which we inherited, or read about them on the web page. We should add a [help overlay](#1143) when pressing <kbd>h</kbd>. Not sure how to expose the shortcuts to visually impaired users other than adding buttons for every action there is a shortcut for, and putting `aria-keyshortcuts` to that. But I am not sure how usable it would be with the 22 shortcuts selfoss currently supports. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #1141 (comment)