Fixed divrem bugs, added pseudo divrem #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a constant by a polynomial.
ahmed-irfan
reviewed
Nov 2, 2023
| @@ -669,7 +719,7 @@ void lp_polynomial_divrem(lp_polynomial_t* D, lp_polynomial_t* R, const lp_polyn | |||
| lp_polynomial_set_context(D, A1->ctx); | |||
| lp_polynomial_set_context(R, A1->ctx); | |||
|
|
|||
| coefficient_divrem(D->ctx, &R->data, &R->data, &A1->data, &A2->data); | |||
| coefficient_divrem(D->ctx, &D->data, &R->data, &A1->data, &A2->data); | |||
ahmed-irfan
reviewed
Nov 2, 2023
| @@ -220,7 +220,7 @@ void lp_polynomial_sub_mul(lp_polynomial_t* S, const lp_polynomial_t* A1, const | |||
| * | |||
| * and | |||
| * | |||
| * P in Z[y] | |||
| * P in Z[x] | |||
There was a problem hiding this comment.
This conflicts with the comment of the coefficient_reduce method. Are you sure about this?
There was a problem hiding this comment.
I forgot to change this at coefficient_reduce as well.
ahmed-irfan
reviewed
Nov 3, 2023
| @@ -159,4 +159,4 @@ def check_comparison(a1, a2, cmp, result, expected): | |||
| p = functools.reduce(lambda x, y: x*y, sample, one) | |||
| random.shuffle(sample) | |||
| p = functools.reduce(lambda x, y: x/y, sample, p) | |||
| polypy_test.check(p == 1) | |||
| polypy_test.check(p == one) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coefficient_divwhen dividing a constant by a non-constant polynomialcoefficient_divremwhen calling with two constant polynomialspolynomial_reduce. Previously it expected lc divisibility rendering it just another divrem functionlp_polynomial_pdivremandlp_polynomial_spdivremfor (sparse) pseudo division with remainder and added python bindings for itlp_polynomial_contextfrom polynomial.hdo {} while(0)for multiple lines, use((void)0)instead of empty command in release builds)