Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetMaxDuration #558

Closed
2 tasks
StaehliJ opened this issue Jun 3, 2024 · 3 comments · Fixed by #659
Closed
2 tasks

GetMaxDuration #558

StaehliJ opened this issue Jun 3, 2024 · 3 comments · Fixed by #659
Assignees
@MGaetan89
Labels
enhancement New feature or request

Comments

@StaehliJ
Copy link
Contributor

StaehliJ commented Jun 3, 2024

As a integrator I want to be able to customize the value of Player.getMaxSeekToPreviousPosition in order to change the time detection in Player.seekToPrevious.

Acceptance criteria

  • MaxSeekToPreviousPosition can be set when initializing Pillarbox player.

Tasks

  • Implement MediaController
  • Implement ExoPlayer
@StaehliJ StaehliJ converted this from a draft issue Jun 3, 2024
@StaehliJ StaehliJ moved this from ✏️ Draft to 📋 Backlog in Pillarbox Jun 3, 2024
@StaehliJ StaehliJ added the enhancement New feature or request label Jun 3, 2024
@MGaetan89 MGaetan89 self-assigned this Jun 4, 2024
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Jun 4, 2024
@MGaetan89
Copy link
Member

I have pushed my initial work to the 558-getmaxduration branch.
I have also opened an issue on androidx/media to propose that it is integrated in Media3 directly. Based on the answer, the branch linked above may be dropped, and we can wait until a Media3 version that provides that feature.

@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Jun 10, 2024
@MGaetan89 MGaetan89 moved this from 🍿 Code Review to 🚧 In Progress in Pillarbox Jun 10, 2024
@MGaetan89
Copy link
Member

A PR has been opened on Media3 to support this feature: androidx/media#1437

@MGaetan89
Copy link
Member

The PR has been released in AndroidX Media3 1.4.0-beta01.

@MGaetan89 MGaetan89 linked a pull request Jul 29, 2024 that will close this issue
Add argument to set Player.getMaxSeekToPreviousPosition when creating a PillarboxExoPlayer #659
Merged
6 tasks
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Jul 29, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGaetan89 MGaetan89

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
2 participants
@MGaetan89 @StaehliJ