Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysipp.server() accepts destaddr as a keyword argument #80

Open
BVollmerhaus opened this issue Jun 10, 2022 · 1 comment
Open

pysipp.server() accepts destaddr as a keyword argument #80

BVollmerhaus opened this issue Jun 10, 2022 · 1 comment
Labels

Comments

@BVollmerhaus
Copy link

pysipp.server() and pysipp.client() appear to be implemented identically, the only exceptions being their respective default scenario name and the fact that pysipp.server() is not supposed to accept a destaddr keyword argument. However, the guard inside the function checks for dstaddr (without the "e"), which I'd assume to be a typo. Since server and client can be used interchangeably, I don't think this has functional implications, though.

@goodboy
Copy link
Member

goodboy commented Dec 19, 2022

@BVollmerhaus please feel free to write a test or example showing your concern more explicitly.

Ideally provide a test demonstrating the typo causing an issue and then provide the fix.

@goodboy goodboy added the bug label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants