-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): make line count header optional #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Add tests for both cases. Feel free to run biome on both parser files and, if possible, add some tsdoc documentation as well.
Done except for tsdoc, while it will be great I think it is outside this scope (and also, if I'm honest, I'm lazy ). |
This is getting noisy, 36 comments, almost all of them from reviewdog 😶 |
yeah, first con of it. |
I used prettier instead of biome
biome config got deleted
4b38bae
to
bd41807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
Biome
src/core/VLIW/VLIWParser.ts|148|
src/core/VLIW/VLIWParser.ts|153|
src/core/VLIW/VLIWParser.ts|158|
src/core/VLIW/VLIWParser.ts|176|
src/test/unit/core/Common/Code.spec.ts|52|
src/test/unit/core/Common/Code.spec.ts|58|
src/test/unit/core/VLIW/VLIWParser.spec.ts|54|
src/test/unit/core/VLIW/VLIWParser.spec.ts|57|
src/test/unit/core/VLIW/VLIWParser.spec.ts|76|
src/test/unit/core/VLIW/VLIWParser.spec.ts|89|
src/test/unit/core/VLIW/VLIWParser.spec.ts|92|
be8070e
to
68ea15a
Compare
For backward compatibility reasons, the code parser support an initial line indicating the number of lines of the code that was ignored but required. As @icasrod pointed, this line shouldn't be required at all. This PR fixes this and also updates the examples shown in the load code modals.