Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Org json files to setting format #25

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

Nickers3
Copy link
Contributor

@Nickers3 Nickers3 commented Jul 3, 2019

Critical Changes

Based on Salesforce Winer 19, you can specify scratch org settings or org preferences in your scratch org definition file, but not both. Salesforce encourages to convert org preferences to scratch org settings in your scratch org definition. Scratch org settings provide more settings that aren’t currently available as org preferences.

Issues Closed

#24

Based on Salesforce Winer 19, you can specify scratch org settings or org preferences in your scratch org definition file, but not both. We encourage you to convert org preferences to scratch org settings in your scratch org definition. Scratch org settings provide more settings that aren’t currently available as org preferences.  This updates the org files to comply.
@Nickers3 Nickers3 requested a review from davisagli July 3, 2019 15:09
@judisohn
Copy link

judisohn commented Jul 3, 2019

Thanks for making the update @Nickers3! We're having to do it across all the product repos as well. :-)

Copy link
Contributor

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually tried creating an org, but the changes look right and the feature test builds appear to have completed successfully.

@Nickers3 Nickers3 merged commit c9c4513 into master Jul 3, 2019
@Nickers3 Nickers3 deleted the OrgPreferenceSettings branch July 3, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants