We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While analyzing context_new I found very confusing identation:
n->component[3] = 0; for (i = 0, tok = str; *tok; i++) { if (i < 3) for (p = tok; *p && *p != ':'; p++) { /* empty */ } else { /* MLS range is one component */ for (p = tok; *p; p++) { /* empty */ } }
The n->component[3] is set above and ven be removed. The for (p = tok; *p && *p != ':'; p++) { braces ends in } else which is confusing. Consider:
n->component[3]
for (p = tok; *p && *p != ':'; p++) {
} else
for (i = 0, tok = str; *tok; i++) { if (i < 3) { for (p = tok; *p && *p != ':'; p++) { /* empty */ } } else { /* MLS range is one component */ for (p = tok; *p; p++) { /* empty */ } }
or
for (i = 0, tok = str; *tok; i++) { /* MLS range is one component */ for (p = tok; *p && (i < 3 || *p != ':'); p++) { /* empty */ }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
While analyzing context_new I found very confusing identation:
The
n->component[3]
is set above and ven be removed. Thefor (p = tok; *p && *p != ':'; p++) {
braces ends in} else
which is confusing. Consider:or
The text was updated successfully, but these errors were encountered: