Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when parsing macro expressions in the middle of a file #306

Closed
enekomartinmartinez opened this issue Jan 3, 2022 · 0 comments · Fixed by #312
Closed

Error when parsing macro expressions in the middle of a file #306

enekomartinmartinez opened this issue Jan 3, 2022 · 0 comments · Fixed by #312
Assignees
@enekomartinmartinez
Labels
bug vensim

Comments

@enekomartinmartinez
Copy link
Collaborator

Our current Vensim parser seems to work properly only when macro expressions are defined at the top. That is why test_macro_trailing_definition test is failing. We need to be able to build the __main__ section taking into account that it can be split by macro definitions.
I already corrected that bug in a branch I am working on, I expect to be able to open a PR of that branch in the following weeks.
@enekomartinmartinez enekomartinmartinez self-assigned this Jan 3, 2022
@enekomartinmartinez enekomartinmartinez changed the title Error qhen parsing macro expressions in a middle of a file Error qhen parsing macro expressions in the middle of a file Jan 7, 2022
@enekomartinmartinez enekomartinmartinez changed the title Error qhen parsing macro expressions in the middle of a file Error when parsing macro expressions in the middle of a file Feb 10, 2022
@enekomartinmartinez enekomartinmartinez mentioned this issue Mar 3, 2022
Merged
15 tasks
@enekomartinmartinez enekomartinmartinez linked a pull request Mar 3, 2022 that will close this issue
PySD v3.0 (Split parsing and building) #312
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enekomartinmartinez enekomartinmartinez

Labels
bug vensim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PySD v3.0 (Split parsing and building) SDXorg/pysd
1 participant
@enekomartinmartinez