Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss and fix PMD / coding style #39

Open
michaelhglass opened this issue Apr 8, 2018 · 4 comments
Open

Discuss and fix PMD / coding style #39

michaelhglass opened this issue Apr 8, 2018 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@michaelhglass
Copy link
Member

Since the codacy integration, we should discuss and agree upon PMDs/coding style we want to respect and then fix this in the codacy configuration. Since those things can also be changed directly in codacy, I assume we will see inconsistent markings. Thus, all those decisions should be reflected and fixed in the project - .codacy.yml may be a good starting point.

@michaelhglass michaelhglass added enhancement New feature or request question Further information is requested labels Apr 8, 2018
@FedorSmirnov89
Copy link
Member

I think the first step here would be to gather all the cases that we want to discuss (or the cases where we disagree with the current codacy code style configuration).

@michaelhglass
Copy link
Member Author

Codacy by default takes configuration files for checkstyle, PMD etc. see https://support.codacy.com/hc/en-us/articles/207994335-Code-Patterns
@felixreimann proposed one checkstyle in the checkstyle branch. I think we should check which standard configurations are out there, create a branch and see what kind of issues they raise and how reasonable/compatible this is to our current style and then go from there. Anyone willing?

@FedorSmirnov89
Copy link
Member

I can do the branch creation and search for the code styles. Then all of us should have a look at it and discuss the whole thing (ideally in a telco).

@FedorSmirnov89
Copy link
Member

FedorSmirnov89 commented Apr 11, 2018

I will create one branch for each code style and add them to my Codacy perspective so that each of us can have a look at the kind of issues that the style results in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants