Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the msvs tests don't run due to a logic flaw #4609

Open
mwichmann opened this issue Oct 7, 2024 · 0 comments · May be fixed by #4610
Open

Some of the msvs tests don't run due to a logic flaw #4609

mwichmann opened this issue Oct 7, 2024 · 0 comments · May be fixed by #4610
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.

Comments

@mwichmann
Copy link
Collaborator

mwichmann commented Oct 7, 2024

As discovered by @jcbrill and mentioned in #4608, some of the tests of building a Visual Studio project file don't run as expected. The tests are

/test/MSVS/vs-files.py
/test/MSVS/vs-scc-files.py
/test/MSVS/vs-scc-legacy-files.py
/test/MSVS/vs-variant_dir.py

In PR #3409, these were made to wrap multiple similar versions to avoid duplicating test code.

The loop that runs these tests ends with test.pass_test(), which quits the running test at that point, as a result only the first pass through the loop actually runs (the current expected list is ['8.0', '9.0', '10.0', '11.0', '12.0', '14.0', '14.1', '14.2', '14.3'], so it misses quite a bit).

In one of the above tests, /test/MSVS/vs-files.py each time through the loop also sets something intentionally strange in os.environ['PYTHON_ROOT'], so that also needs to be reset before proceeding or the next pass through the loop will fail.

@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Oct 7, 2024
@jcbrill jcbrill linked a pull request Oct 7, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant