Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added worker password support #280

Closed
wants to merge 1 commit into from
Closed

Conversation

BadTigrou
Copy link
Contributor

@BadTigrou BadTigrou commented Oct 3, 2023

Small modifications to take into account the pass value sent by workers.
It shows up in the workers command and in the stratum file of the api (as the login value).

There is no real authentication.

It just allow miners to use the pass arguments to provide any value as login.

@SChernykh
Copy link
Owner

I don't think it's necessary in p2pool. First of all, it's not a real password. Regular pools use it for rig names because user field is used for wallet address. In p2pool, the wallet address is set on pool side, so user field can be used for anything, and password is not needed.

@BadTigrou
Copy link
Contributor Author

BadTigrou commented Oct 4, 2023

i personally use it to put the bay location of my workers. i agree that it's not a real password. it just gives the possibility to add a second label to your workers.

@SChernykh
Copy link
Owner

XMRig has rig-id parameter exactly for this purpose: https://github.com/xmrig/xmrig/blob/master/src/config.json#L68
I gets passed as rigid in the login JSON in Stratum protocol: https://github.com/xmrig/xmrig/blob/master/src/base/net/stratum/Client.cpp#L628

@BadTigrou
Copy link
Contributor Author

So you are in favor of implementation of rigid instead of password ?
The use case is the same to me the name of the field is not really relevant in my opinion

@SChernykh
Copy link
Owner

Yes, rigid makes more sense.

@BadTigrou BadTigrou closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants