Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check comportement when switching canvas #46

Closed
Drilio opened this issue Mar 11, 2024 · 9 comments
Closed

Check comportement when switching canvas #46

Drilio opened this issue Mar 11, 2024 · 9 comments

Comments

@Drilio
Copy link
Collaborator

Drilio commented Mar 11, 2024

Our pannel check manifest type at the top logic but what if a manifest contain differents canvas ?

@daxid
Copy link
Member

daxid commented Mar 12, 2024

@Drilio @geourjoa A test manifest with different media types on canvases is here : https://files.tetras-libre.fr/dev/Heterogeneous-media-on-several-canvases.json

@Drilio
Copy link
Collaborator Author

Drilio commented Mar 12, 2024

Our major problems come from annotationDrawing, everything in this part of code is based on this logic :
is there an Image ? If not do the video thing..
But this logic doesn't work with the way Mirador handle differents canvas type.

I'll create a branch and try some major changes to see if a change on how the logic is handle could lead to something better.

@Drilio
Copy link
Collaborator Author

Drilio commented Mar 12, 2024

What we are intersting in is :
0>__jsonld>items>0>items>0>body>type

Image Canvases information :

Image

Video Canvases information:

Image

Audio Canvases Information :

Image

@Drilio
Copy link
Collaborator Author

Drilio commented Mar 12, 2024

Canvases = Actual displaying canvas

@Drilio
Copy link
Collaborator Author

Drilio commented Mar 13, 2024

Problem :
The app crash when switching canvas while panel annotation is selected with template.

Reproduce :

  • open pannel annotation
  • choose a template
  • switch canvas

@Drilio
Copy link
Collaborator Author

Drilio commented Mar 13, 2024

I fixed it there :

@geourjoa
Copy link
Contributor

  • The canva size is not refreshed when switching video to image

To reproduce use : https://files.tetras-libre.fr/dev/Heterogeneous-media-on-several-canvases.json

  • Go to image (canva 1)
  • Draw a target
  • Go to video (Canva 2)
  • Move the object
  • Return to image (canva 1)
  • The object can only move on the video size

@geourjoa
Copy link
Contributor

geourjoa commented Jan 7, 2025

Stuff must be improved in player references

@geourjoa
Copy link
Contributor

tested on MAE with heterogeneous Manifest, https://files.tetras-libre.fr/dev/Heterogeneous-media-on-several-canvases.json

No issues and information message display correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants