Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some manifests cause crash #109

Closed
geourjoa opened this issue Sep 24, 2024 · 7 comments
Closed

Some manifests cause crash #109

geourjoa opened this issue Sep 24, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@geourjoa
Copy link
Contributor

This manifest can break MAE only in beeing in the manifest catalog.

"https://dzkimgs.l.u-tokyo.ac.jp/videos/iiif_in_japan_2017/manifest.json"

I think it is the old manifest format

To reproduce :

  • Open stock MAE
  • Open a manifest
  • Click on x in top left

App crash on manifest.js L142

image

image

@geourjoa geourjoa added the bug Something isn't working label Sep 24, 2024
@geourjoa
Copy link
Contributor Author

Bug come manifesto and IIIFResources.js

I dont know why error break mae and not Mirador Stock

image

@geourjoa
Copy link
Contributor Author

I don't lose more time on it, I only remove this breaking manifest from default catalog.

@geourjoa geourjoa changed the title Some manifest cause crash Some manifests cause crash Sep 24, 2024
@daxid
Copy link
Member

daxid commented Sep 25, 2024

Yes @geourjoa Lets keep this open and see if we figure out what's going on.

The Manifest is announced as using Presentation API v3 (the last) so it should not be considered as an "old" manifest.

Could the japanese characters inside it be the reason ?

@geourjoa
Copy link
Contributor Author

geourjoa commented Nov 12, 2024

I dont know why but now same error are now breaking mirador video

image

@geourjoa
Copy link
Contributor Author

geourjoa commented Nov 12, 2024

Ok, i have a lead

I downgrade manifesto.js 4.20.20 to 4.20.17 and it seem to work

https://www.npmjs.com/package/manifesto.js?activeTab=versions

@geourjoa
Copy link
Contributor Author

I need also to force the addition of multiple package.

npm install react-sizeme
npm i @babel/plugin-proposal-private-property-in-object
npm i @babel/plugin-proposal-object-rest-spread
npm i

I use currently node 18 on this project

@geourjoa
Copy link
Contributor Author

PR : SCENE-CE/mirador-video#5

@geourjoa geourjoa closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants