Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possiblity to specify extension in editor (fixes #914) #998

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Add possiblity to specify extension in editor (fixes #914) #998

merged 2 commits into from
Feb 25, 2021

Conversation

GenieTim
Copy link
Contributor

@GenieTim GenieTim commented Feb 23, 2021

With these changes, it is possible to add an extension to the tmp file used by the editor in order to enable syntax highlighting etc.

This PR fixes issue #914

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #998 (45a8555) into master (a3ddaa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          27       27           
  Lines        1121     1121           
  Branches       23       23           
=======================================
  Hits         1046     1046           
  Misses         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ddaa0...45a8555. Read the comment docs.

Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants