Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-notification-list]: Sample issue #10526

Open
1 task done
petyabegovska opened this issue Jan 13, 2025 · 0 comments · May be fixed by #10626
Open
1 task done

[ui5-notification-list]: Sample issue #10526

petyabegovska opened this issue Jan 13, 2025 · 0 comments · May be fixed by #10626
Assignees
@kskondov
Labels
bug This issue is a bug in the code Low Prio TOPIC RD

Comments

@petyabegovska
Copy link
Collaborator

petyabegovska commented Jan 13, 2025 •
edited
Loading

Bug Description

Hello @SAP/ui5-webcomponents-topic-rd,

Please check why the ui5-toast doesn't appear in sample:
https://sap.github.io/ui5-webcomponents/nightly/components/fiori/NotificationList/#basic-sample

Best regards,
Petya

Affected Component

ui5-notification-list

Expected Behaviour

No response

Isolated Example

https://sap.github.io/ui5-webcomponents/nightly/components/fiori/NotificationList/#basic-sample

Steps to Reproduce

  1. Open sample: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/NotificationList/#basic-sample
  2. Click on an action of the menu of the first Notification List element

...

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

Nightly

Browser

Safari

Operating System

macOS

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@petyabegovska petyabegovska added bug This issue is a bug in the code Low Prio TOPIC RD labels Jan 13, 2025
@kskondov kskondov self-assigned this Jan 21, 2025
kskondov added a commit that referenced this issue Jan 22, 2025
@kskondov
fix(ui5-notification-list): corrects misusage of ui5-toast
b464182 
The sample in the playground used toast.show() method
which was deprecated and this resulted in the ui5-toast
not showing in the playground sample

Fixes: #10526
@kskondov kskondov linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kskondov kskondov

Labels
bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: New Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-notification-list): corrects misusage of ui5-toast SAP/ui5-webcomponents
2 participants
@kskondov @petyabegovska