refactor(enums): harmonize enum names #5970
Merged
+104
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `MessageBoxActions` enum has been renamed to `MessageBoxAction` BREAKING CHANGE: the `MessageBoxTypes` enum has been renamed to `MessageBoxType` BREAKING CHANGE: the `Themes` enum has been renamed to `Theme`
|
Size Change: -27 B (-0.01%) Total Size: 403 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 9659512079Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9660197009Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9660378417Details
💛 - Coveralls |
Lukas742
reviewed
Jun 25, 2024
| sap_horizon_hcw = 'sap_horizon_hcw', | ||
| sap_belize = 'sap_belize', | ||
| sap_belize_hcb = 'sap_belize_hcb', | ||
| sap_belize_hcw = 'sap_belize_hcw' | ||
| sap_horizon_hcw = 'sap_horizon_hcw' |
There was a problem hiding this comment.
I've removed the deprecated Belize theme family, but I'm not sure if we should offer a codemod for this. We could set it to the default (sap_horizon) but this could be undesired in some cases. Maybe it's better that we leave it up to app developers to decide what theme they'll use as replacement. WDYT?
I've also adjusted the breaking change note accordingly.
Lukas742
approved these changes
Jun 25, 2024
Pull Request Test Coverage Report for Build 9661572094Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9661572094Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Lukas742
pushed a commit
that referenced
this pull request
Jun 25, 2024
BREAKING CHANGE: the `MessageBoxActions` enum has been renamed to `MessageBoxAction` BREAKING CHANGE: the `MessageBoxTypes` enum has been renamed to `MessageBoxType` BREAKING CHANGE: the `Themes` enum has been renamed to `Theme` and the deprecated "Belize" (`sap_belize`) theme family has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the
MessageBoxActionsenum has been renamed toMessageBoxActionBREAKING CHANGE: the
MessageBoxTypesenum has been renamed toMessageBoxTypeBREAKING CHANGE: the
Themesenum has been renamed toThemeand the deprecated "Belize" (sap_belize) theme family has been removed