Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy control to console #215

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

erlethor
Copy link
Contributor

Copy Control to Console

The feature is Inspired by the Store ... as global variable feature of the chrome dev. tools debugger.

A click on the id of a control in the Properties tab of the Control Inspector as well as of the Elements Registry or on the button Copy to console in the Action tab of the Control Inspector will create a global variable starting with 'ui5$' and a number e.g. 'ui5$0' that refers to this control. All control references will be collected in the variable ui5$temp for convenience.

The control is not directly assigned to the global variable but wrapped in an object showing the class of the control in the property isA. The actual control is in the property control.

image

The savedAs property is helpful when looking at all collected globals in ui5$temp.

image

The feature is offered using the following interactions:

  • Click on the id of a control in the Properties tab of the Control Inspector

image

  • Click on the id of a control in the Properties tab of the Elements Registry

image

  • Click button Copy to console in the Action tab of the Control Inspector

image

A click on the id of a control in the properties
tab or on the button 'Copy to console' in the
Action tab will create a temp global variable
starting with 'ui5$' and a number e.g. 'ui5$0'
that refers to the control. All controls
will be collected in the variable 'ui5$temp' for
convenience.
@jdichev
Copy link
Contributor

jdichev commented Jan 9, 2023

Hello @erlethor,
Thanks for your contribution. We're going to shortly review this PR under ref. BGSOFUIPIRIN-5853
Best regards,
Jordan

Copy link
Contributor

@kineticjs kineticjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and pls excuse us for taking so long... The team reacted extremely positively on the demo of this contribution... we expect the feature will certainly be used ..

@kineticjs kineticjs merged commit 0fd04d9 into SAP:master Jan 23, 2023
@erlethor erlethor deleted the copy-control-to-console branch January 23, 2023 15:13
@erlethor
Copy link
Contributor Author

@kineticjs Thank you Diana. I am glad the team likes the feature.

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants