Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove invalid parameter #201

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix: remove invalid parameter #201

merged 2 commits into from
Oct 28, 2022

Conversation

kineticjs
Copy link
Contributor

  1. Remove invalid parameter passed to the utils.sendToAll function that called an "invalid signature" error from chrome
  2. Ensured that the iframe URL is shown in the frames dropdown even the iframe has no UI5 content

@kineticjs kineticjs marked this pull request as ready for review October 26, 2022 16:48
@kineticjs kineticjs merged commit 2d060f1 into SAP:master Oct 28, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova PetyaMarkovaBogdanova approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kineticjs @PetyaMarkovaBogdanova