Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(environment): adjust getEnvironment exception handling #89

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Phil91
Copy link
Collaborator

@Phil91 Phil91 commented Aug 20, 2024

Description

Adding error handling for getEnvironmentId to check for non existing environments

Why

The check for tenant environments did only check for > 1 not any

Issue

Refs: #84 #87

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 force-pushed the bugfix/84-service-exception branch from 96eb97b to 81e2bf2 Compare August 21, 2024 09:09
@Phil91 Phil91 requested a review from evegufy September 9, 2024 07:49
@Phil91 Phil91 added the priority label Sep 9, 2024
@Phil91 Phil91 merged commit 8b526a5 into main Sep 12, 2024
8 checks passed
@Phil91 Phil91 deleted the bugfix/84-service-exception branch September 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants