Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callback): add error handling for callback service #73

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Phil91
Copy link
Collaborator

@Phil91 Phil91 commented Jul 31, 2024

Description

add error handling to the callback service

Why

Currently the callback is send without a check if the call was successful, this results in the process step always succeeding even if the callback call failed.

Issue

Refs: #67

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy July 31, 2024 14:07
@Phil91 Phil91 force-pushed the bugfix/67-callback-errorhandling branch from b4e4c7c to ecb5f04 Compare August 2, 2024 06:21
@Phil91 Phil91 requested a review from evegufy August 2, 2024 06:21
@Phil91 Phil91 merged commit 9db2959 into main Aug 2, 2024
7 checks passed
@Phil91 Phil91 deleted the bugfix/67-callback-errorhandling branch August 2, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants