Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add existence check for wallet creation #71

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Phil91
Copy link
Collaborator

@Phil91 Phil91 commented Jul 31, 2024

Description

  • adjust api Post: api/dim/setup-dim to include an existence check for companyName and bpn, if an entry already exists an exception is thrown

Why

When trying to create the wallet with the same key "company_name"_"bpn" the wallet creation will fail, therefore the check of existence is added in the api

Issue

Refs: #66

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@evegufy
Copy link
Collaborator

evegufy commented Jul 31, 2024

@Phil91 thanks for the change.
I'd like to get the patch version finalized for the 1.2.0 version before merging another feature as this should be properly tested and part of a minor version.

@Phil91 Phil91 force-pushed the feature/66-existence branch from d70c28a to bbd4c20 Compare August 2, 2024 14:24
@Phil91 Phil91 requested a review from evegufy August 2, 2024 14:24
@Phil91 Phil91 merged commit c23dfe1 into main Aug 2, 2024
7 checks passed
@Phil91 Phil91 deleted the feature/66-existence branch August 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants