From 12501792caa93e1088914877781958cf3b3ffc9b Mon Sep 17 00:00:00 2001 From: Caine Rotherham Date: Tue, 10 Dec 2024 17:01:55 +0100 Subject: [PATCH] revert: "fix: a11yPasswordVisibilityBtnValueOverflow typo (#19531)" (#19756) --- .../csagent-login-form/csagent-login-form.component.ts | 2 +- .../order-guest-register-form.component.ts | 2 +- .../user-change-password-form.component.ts | 2 +- .../account/components/login-form/login-form.component.ts | 2 +- .../components/otp-login-form/otp-login-form.component.ts | 2 +- .../profile/components/register/register.component.ts | 2 +- .../components/reset-password/reset-password.component.ts | 2 +- .../components/update-email/update-email.component.ts | 2 +- .../update-password/my-account-v2-password.component.ts | 2 +- .../update-password/update-password.component.ts | 2 +- .../feature-toggles/config/feature-toggles.ts | 4 ++-- .../src/app/spartacus/spartacus-features.module.ts | 2 +- projects/storefrontstyles/scss/cxbase/blocks/forms.scss | 8 +++++--- 13 files changed, 18 insertions(+), 16 deletions(-) diff --git a/feature-libs/asm/components/csagent-login-form/csagent-login-form.component.ts b/feature-libs/asm/components/csagent-login-form/csagent-login-form.component.ts index 501ade2bda2..fdbd9b668ae 100644 --- a/feature-libs/asm/components/csagent-login-form/csagent-login-form.component.ts +++ b/feature-libs/asm/components/csagent-login-form/csagent-login-form.component.ts @@ -26,7 +26,7 @@ export class CSAgentLoginFormComponent implements OnInit { submitEvent = new EventEmitter<{ userId: string; password: string }>(); constructor(protected fb: UntypedFormBuilder) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); useFeatureStyles('a11yTextSpacingAdjustments'); } diff --git a/feature-libs/order/components/order-confirmation/order-guest-register-form/order-guest-register-form.component.ts b/feature-libs/order/components/order-confirmation/order-guest-register-form/order-guest-register-form.component.ts index 30b3c65a039..8a6478595cd 100644 --- a/feature-libs/order/components/order-confirmation/order-guest-register-form/order-guest-register-form.component.ts +++ b/feature-libs/order/components/order-confirmation/order-guest-register-form/order-guest-register-form.component.ts @@ -74,7 +74,7 @@ export class OrderGuestRegisterFormComponent implements OnDestroy { protected authService: AuthService, protected fb: UntypedFormBuilder ) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } submit() { diff --git a/feature-libs/organization/administration/components/user/change-password-form/user-change-password-form.component.ts b/feature-libs/organization/administration/components/user/change-password-form/user-change-password-form.component.ts index 66bb3896e39..4b12b2e4f95 100644 --- a/feature-libs/organization/administration/components/user/change-password-form/user-change-password-form.component.ts +++ b/feature-libs/organization/administration/components/user/change-password-form/user-change-password-form.component.ts @@ -30,7 +30,7 @@ export class UserChangePasswordFormComponent { protected formService: UserChangePasswordFormService, protected messageService: MessageService ) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } save(form: UntypedFormGroup): void { diff --git a/feature-libs/user/account/components/login-form/login-form.component.ts b/feature-libs/user/account/components/login-form/login-form.component.ts index ab66e28c602..80221969a66 100644 --- a/feature-libs/user/account/components/login-form/login-form.component.ts +++ b/feature-libs/user/account/components/login-form/login-form.component.ts @@ -17,7 +17,7 @@ import { LoginFormComponentService } from './login-form-component.service'; }) export class LoginFormComponent { constructor(protected service: LoginFormComponentService) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } form: UntypedFormGroup = this.service.form; diff --git a/feature-libs/user/account/components/otp-login-form/otp-login-form.component.ts b/feature-libs/user/account/components/otp-login-form/otp-login-form.component.ts index 0d302c91471..65f5ad8eb21 100644 --- a/feature-libs/user/account/components/otp-login-form/otp-login-form.component.ts +++ b/feature-libs/user/account/components/otp-login-form/otp-login-form.component.ts @@ -59,7 +59,7 @@ export class OneTimePasswordLoginFormComponent { @HostBinding('class.user-form') style = true; constructor() { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } onSubmit(): void { diff --git a/feature-libs/user/profile/components/register/register.component.ts b/feature-libs/user/profile/components/register/register.component.ts index 6a4535a7307..df07f8665ed 100644 --- a/feature-libs/user/profile/components/register/register.component.ts +++ b/feature-libs/user/profile/components/register/register.component.ts @@ -124,7 +124,7 @@ export class RegisterComponent implements OnInit, OnDestroy { protected authConfigService: AuthConfigService, protected registerComponentService: RegisterComponentService ) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } ngOnInit() { diff --git a/feature-libs/user/profile/components/reset-password/reset-password.component.ts b/feature-libs/user/profile/components/reset-password/reset-password.component.ts index 90527875495..a2cca056396 100644 --- a/feature-libs/user/profile/components/reset-password/reset-password.component.ts +++ b/feature-libs/user/profile/components/reset-password/reset-password.component.ts @@ -23,7 +23,7 @@ export class ResetPasswordComponent { token$: Observable = this.service.resetToken$; constructor(protected service: ResetPasswordComponentService) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } onSubmit(token: string) { diff --git a/feature-libs/user/profile/components/update-email/update-email.component.ts b/feature-libs/user/profile/components/update-email/update-email.component.ts index ec074c50f93..16dd3a48785 100644 --- a/feature-libs/user/profile/components/update-email/update-email.component.ts +++ b/feature-libs/user/profile/components/update-email/update-email.component.ts @@ -18,7 +18,7 @@ import { UpdateEmailComponentService } from './update-email-component.service'; }) export class UpdateEmailComponent { constructor(protected service: UpdateEmailComponentService) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } form: UntypedFormGroup = this.service.form; diff --git a/feature-libs/user/profile/components/update-password/my-account-v2-password.component.ts b/feature-libs/user/profile/components/update-password/my-account-v2-password.component.ts index 59506cedbe6..95f3e047f2f 100644 --- a/feature-libs/user/profile/components/update-password/my-account-v2-password.component.ts +++ b/feature-libs/user/profile/components/update-password/my-account-v2-password.component.ts @@ -27,7 +27,7 @@ export class MyAccountV2PasswordComponent { isUpdating$: Observable = this.service.isUpdating$; constructor() { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } onSubmit(): void { diff --git a/feature-libs/user/profile/components/update-password/update-password.component.ts b/feature-libs/user/profile/components/update-password/update-password.component.ts index 76094829502..c0278f3f0b9 100644 --- a/feature-libs/user/profile/components/update-password/update-password.component.ts +++ b/feature-libs/user/profile/components/update-password/update-password.component.ts @@ -27,7 +27,7 @@ export class UpdatePasswordComponent { }); constructor(protected service: UpdatePasswordComponentService) { - useFeatureStyles('a11yPasswordVisibilityBtnValueOverflow'); + useFeatureStyles('a11yPasswordVisibliltyBtnValueOverflow'); } form: UntypedFormGroup = this.service.form; diff --git a/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts b/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts index b2cb73a0432..a30b097436b 100644 --- a/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts +++ b/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts @@ -642,7 +642,7 @@ export interface FeatureTogglesInterface { /** * Stops the inputs value from obstructing the 'PasswordVisibilityToggleComponent'. */ - a11yPasswordVisibilityBtnValueOverflow?: boolean; + a11yPasswordVisibliltyBtnValueOverflow?: boolean; /** * In `ItemCounterComponenet`, Remove button no longer lose focus after activating when count is 2. @@ -959,7 +959,7 @@ export const defaultFeatureToggles: Required = { a11yAddToWishlistFocus: false, a11ySearchBoxFocusOnEscape: false, a11yUpdatingCartNoNarration: false, - a11yPasswordVisibilityBtnValueOverflow: false, + a11yPasswordVisibliltyBtnValueOverflow: false, a11yItemCounterFocus: false, a11yScrollToReviewByShowReview: false, a11yViewHoursButtonIconContrast: false, diff --git a/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts b/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts index 46445775b58..c9fcc8b8b50 100644 --- a/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts +++ b/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts @@ -389,7 +389,7 @@ if (environment.cpq) { a11yAddToWishlistFocus: true, a11ySearchBoxFocusOnEscape: true, a11yUpdatingCartNoNarration: true, - a11yPasswordVisibilityBtnValueOverflow: true, + a11yPasswordVisibliltyBtnValueOverflow: true, a11yItemCounterFocus: true, a11yScrollToReviewByShowReview: true, a11yViewHoursButtonIconContrast: true, diff --git a/projects/storefrontstyles/scss/cxbase/blocks/forms.scss b/projects/storefrontstyles/scss/cxbase/blocks/forms.scss index e74ee9f3d7c..d8d0512a6ae 100644 --- a/projects/storefrontstyles/scss/cxbase/blocks/forms.scss +++ b/projects/storefrontstyles/scss/cxbase/blocks/forms.scss @@ -510,8 +510,10 @@ form { } input[cxpasswordvisibilityswitch] { - @include forFeature('a11yPasswordVisibilityBtnValueOverflow') { - $password-visibility-btn-width: 30px; - padding-inline-end: calc($password-visibility-btn-width + $input-padding-x); + @include forFeature('a11yPasswordVisibliltyBtnValueOverflow') { + $password-visibbility-btn-width: 30px; + padding-inline-end: calc( + $password-visibbility-btn-width + $input-padding-x + ); } }