Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The paths defined in the ui5.yml is not detected automatically #56

Open
zhangliangyi opened this issue Apr 18, 2019 · 4 comments
Open
Assignees

Comments

@zhangliangyi
Copy link

zhangliangyi commented Apr 18, 2019

Hi Colleague,

I am working on the migration of this plugin in SAP Successfactors.

I noticed the new version has imported some new configuration such as type and paths. And I found there is a method called autoDetectType which will scan the ui5.yaml in the module root path to get the module type. It is wonderful and I really like this.

I suppose that this auto detect mechanism would find the paths I defined in the .yaml file as well. But so far it seems only reading the type property.

Here is the ui5.yaml in my module,

specVersion: '0.1'
resources:
  configuration:
    paths:
      webapp: /src/main/uilib/sap/sf/todo/
metadata:
  name: au-todo-sap.sf.todo-web
type: application

Just wonder if this plugin can detect the paths defined in this way so that I don't need add the paths into karma configuration again.

@matz3 matz3 self-assigned this Apr 18, 2019
@matz3
Copy link
Member

matz3 commented Apr 18, 2019

Yes, this is some missing part we currently have.
It's planned that we are using the UI5 Tooling APIs to get all relevant information about the project (incl. ui5.yaml). Right now we are manually parsing the file, which was just a quick solution.

@zhangliangyi
Copy link
Author

@matz3
Thanks for the quick response. I will keep track of this issue.

@matz3
Copy link
Member

matz3 commented Oct 9, 2019

karma v4.3.0 added support for plugins to be loaded async (karma-runner/karma#3297). This might be helpful as most UI5 Tooling APIs are async. This is the reason some parts within this plugin are done manually (e.g. reading ui5.yaml).

@matz3
Copy link
Member

matz3 commented Nov 22, 2021

Reopening, as this hasn't been solved yet.

@matz3 matz3 reopened this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants