Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitesource does not work anymore #4513

Closed
Elena6789 opened this issue Aug 15, 2023 · 6 comments
Closed

Whitesource does not work anymore #4513

Elena6789 opened this issue Aug 15, 2023 · 6 comments

Comments

@Elena6789
Copy link

Elena6789 commented Aug 15, 2023

Hi ,
please review this commit 69347fe.
Whitesource fails since it is in.
by doing this it works(or pin v1.304.0 directly in the Jenkins configuration instead of working with master):

  withEnv(['REPOSITORY_UNDER_TEST=SAP/jenkins-library', 'LIBRARY_VERSION_UNDER_TEST=v1.304.0']) {
                                      		  whitesourceExecuteScan script: this,
                                               		buildDescriptorFile: 'approuter/package.json',
                                               		scanPath: 'approuter',
                                               		buildTool: 'npm'
					  	 }
@Menderlem
Copy link

Hi,
our pipelines are failing as well. It looks like already processed security findings are not ignored anymore which causes the build to fail. In Whitesource there is nothing to do since the mentioned findings are already handled.

@StephanDuby
Copy link

Also happening to our pipes with a single ignored vulnerability

@anilkeshav27
Copy link
Member

@andrew-kireev , @sumeetpatil , tagging you since there was a fix about ignoring vulnerability , is this also related to or a different issue ?

@Elena6789
Copy link
Author

There was a fix with this PR #4518. I did not test myself so I cannot confirm if it is working. If someone else tested and it works we could close the issue.

@StephanDuby
Copy link

I used the workaround today.
I will remove and see if the update works and give feedback here tomorrow when in the office

@Menderlem
Copy link

The fix with PR #4518 seems to work. Today's nightly run is working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants