Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schema references to a non-Github domain? #83

Closed
esjewett opened this issue May 7, 2021 · 4 comments · Fixed by #233
Closed

Move schema references to a non-Github domain? #83

esjewett opened this issue May 7, 2021 · 4 comments · Fixed by #233

Comments

@esjewett
Copy link

esjewett commented May 7, 2021

This is a little nit-picky, but I think Github really doesn't like tooling to reference https://raw.githubusercontent.com. I'd suggest using Github Pages or another system to publish the schema files onto a CDN-backed infrastructure and bake that URL into the schemas so that it doesn't have to change in the future. I'd guess that SAP will eventually want to host these somewhere under sap.com.

@larshp
Copy link
Collaborator

larshp commented May 7, 2021

yea, agree, but its not that far yet

there is also https://www.schemastore.org

but I'd probably suggest a custom domain

@larshp
Copy link
Collaborator

larshp commented Jul 7, 2021

well, even that the schema is not specified in the files, as I'd wish it all to work offline also

also relevant = #53

@larshp
Copy link
Collaborator

larshp commented Jul 8, 2021

Suggest: removing the $schema field from the serialized json file

@albertmink albertmink mentioned this issue Sep 21, 2021
@albertmink albertmink linked a pull request Sep 22, 2021 that will close this issue
@albertmink albertmink linked a pull request Sep 23, 2021 that will close this issue
@albertmink
Copy link
Contributor

Implemented for object type INTF in #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants