-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENHO callbackClass #409
Comments
It is required, because the subschema of the filter_values is complicated (it has "oneOf", "anyOf", "maxItems"...) and can not be generated by the infos provided by if_aff_enho_v1 alone. |
or in other words, the JSON type cannot be mapped to a static ABAP type eg. just like conditional subschemas cannot be mapped to ABAP types |
for reference, abapGit serializes structure |
my suggestion: string |
One proposal to change it by @larshp to The string can contain IF-condition like |
Options I see so far:
"! <p class="shorttext">Filter Condition</p>
"! Filter condition
TYPES ty_value TYPE string.
TYPES:
"! <p class="shorttext">OR Filter Conditions</p>
"! OR filter conditions
BEGIN OF ty_or,
"! <p class="shorttext">Filter Condition</p>
"! Simple filter condition
value TYPE ty_value,
END OF ty_or.
TYPES:
"! <p class="shorttext">AND Filter Conditions</p>
"! AND filter conditions
BEGIN OF ty_and,
"! <p class="shorttext">Filter Condition</p>
"! Simple filter condition
value TYPE ty_value,
"! <p class="shorttext">OR Filter Conditions</p>
"! OR filter conditions
or TYPE standard table of ty_or with default key,
END OF ty_and.
TYPES:
"! <p class="shorttext">OR Filter Conditions</p>
"! OR filter conditions on top level
BEGIN OF ty_or_top,
"! <p class="shorttext">Filter Condition</p>
"! Simple filter condition
value TYPE ty_value,
"! <p class="shorttext">AND Filter Conditions</p>
"! AND filter conditions
and TYPE standard table of ty_and with default key,
END OF ty_or_top.
TYPES:
"! <p class="shorttext">Filter Values</p>
"! Filter values
BEGIN OF ty_filter_values,
"! <p class="shorttext">Filter Value</p>
"! Filter value
value TYPE ty_value,
"! <p class="shorttext">OR Filter Conditions</p>
"! OR filter conditions
or TYPE standard table of ty_or_top with default key,
"! <p class="shorttext">AND Filter Conditions</p>
"! AND filter conditions
and TYPE standard table of ty_and with default key,
END OF ty_filter_values. |
as the only type, ENHO contains
"! $callbackClass {@link cl_seef_aff_enho_filter_st}
, this is something outside this repository, so I cannot really tell what it isis it required?
https://github.com/SAP/abap-file-formats/blob/main/file-formats/enho/type/zif_aff_enho_v1.intf.abap#L261
The text was updated successfully, but these errors were encountered: