DDLS: is .objectdependencies.json valid for code review?

[larshp]

I dont exactly know what the objectdependencies/baseinfo in a DDLS is for.

But if its required(and it probably is), then I'd argue that its very valid for review.

The baseinfo must be correct, ie it must be reviewed, a developer might forget staging and pushing, or when editing the files manually something must be put into the file?

Two scenarios:
A: its valid for review, then I suggest adding the information to the main JSON file instead of having multiple files
B: its not valid, then the file can be removed as a part of file formats

[BeckerWdf]

It's no valid for code reviews but it's needed for use-cases where you import DDLS object from git.
So one could configure it that these files are ignored for code reviews.

[larshp]

from my point of view, focusing on code reviews is not the scope of this effort

[BeckerWdf]

from my point of view, focusing on code reviews is not the scope of this effort

What do you mean? Can you describe in more detail?

[BeckerWdf]

In #167 311 we removed this file. So this is not longer an issue.