This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Use os sdk #58
Merged
Use os sdk #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@florian-richter, please review. |
florian-richter
suggested changes
Mar 10, 2020
| if (await cli.confirm('Do you want to install the @sap/cloud-sdk-generator globally? (y|n)')) { | ||
| await execa('npm', ['install', '--global', '--@sap:registry=https://npm.sap.com', '@sap/cloud-sdk-generator']); | ||
| if (await cli.confirm('Do you want to install the @sap-cloud-sdk/generator globally? (y|n)')) { | ||
| await execa('npm', ['install', '--global', '--@sap:registry=https://npm.sap.com', '@sap-cloud-sdk/generator']); |
There was a problem hiding this comment.
--@sap:registry=https://npm.sap.com should be removed otherwise the dependency will not be found
There was a problem hiding this comment.
I tried to remove this, then the pipeline failed:
https://github.com/SAP/cloud-sdk-cli/runs/497189204?check_suite_focus=true
Then I fixed it by reverting the change:
3a136e6
florian-richter
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
use os sdk
Checklist