This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Fix package command problems #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2020 16:01
mr-flannery
reviewed
Jan 7, 2020
test/package.spec.ts
Outdated
| fs.copySync(nestAppDir, projectDir, { recursive: true }); | ||
| await Package.run([projectDir, '--skipInstall']); | ||
|
|
||
| expect(fs.readdirSync(path.resolve(projectDir, 'deployment'))).toIncludeAllMembers(['package.json', 'package-lock.json']); |
There was a problem hiding this comment.
From my understanding this tests the default value for --include. Shouldn't this test assert then that all files included by default are copied (i.e. package.json, package-lock.json, index.js, dist/**/*)?
There was a problem hiding this comment.
for the default nest.js app does not have an index.js and the dist/** only appear after compiling (which I dont test here). That's why I implemented it this way, but I am open for improvement suggestions.
There was a problem hiding this comment.
I see. Is there something like toIncludeAndOnlyIncludeAllMembers? =P
mr-flannery
approved these changes
Jan 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.