Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Enable analytics #23

Merged
merged 6 commits into from
Dec 6, 2019
Merged

Enable analytics #23

merged 6 commits into from
Dec 6, 2019

Conversation

florian-richter
Copy link
Contributor

@florian-richter florian-richter commented Dec 6, 2019

Proposed Changes

Generate the necessary file (if given consent) to send analytics.

Type of Changes

  • Bug Fix
  • New Feature
  • Documentation Update

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Breaking Changes

In general avoid breaking changes, but if you think it is necessary give your reasoning in the Further Comments section.

  • I have not introduced breaking changes

Further Comments

If the changes are complex, please discuss what alternatives you have evaluated and why you picked this particular solution. Please make sure to highlight any trade-offs that we should know about.

@@ -30,6 +40,10 @@ export default class Init extends Command {
hidden: true,
description: 'If the folder is empty, use nest-cli to create a project scaffold.'
}),
analytics: flags.boolean({
hidden: true,
description: 'Set analytics as enabled or disabled.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enable collection of anonymous usage data."

src/commands/init.ts Show resolved Hide resolved
src/utils/usage-analytics.ts Show resolved Hide resolved
Copy link
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@florian-richter florian-richter merged commit 6f6367e into master Dec 6, 2019
@florian-richter florian-richter deleted the enable-analytics branch December 6, 2019 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants