This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Use nest-cli via npx only #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Previously I added the @nestjs/cli as a dependency to speed up tests (as npx will always download packages if the name of the package and the executable are different). But it brings in a lot of subdependencies and the tests don't actually test the real life behavior.
Most test now us the pre-generated nest project and all other assertions are now in one test to avoid unnecessary downloads.
Checklist
Breaking Changes
In general avoid breaking changes, but if you think it is necessary give your reasoning in the Further Comments section.