Hotfix wrong or unnecessary warnings (#45)

SAP-archive · Jan 9, 2020 · 06f1edb · 06f1edb
1 parent 1d68183
commit 06f1edb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/utils/package-json.ts b/src/utils/package-json.ts
@@ -155,7 +155,7 @@ async function addDependencyVersions(dependencies: string[] = []): Promise<{ [ke
 async function getVersionOfDependency(dependency: string): Promise<string> {
   try {
     const args = ['view', dependency, 'version'];
-    const version = dependency.includes('@sap') ? execa('npm', [...args, '--registry', 'https://npm.sap.com']) : execa('npm', args);
+    const version = dependency.includes('@sap/') ? execa('npm', [...args, '--registry', 'https://npm.sap.com']) : execa('npm', args);
 
     return `^${(await version).stdout}`;
   } catch (e) {

diff --git a/src/utils/scaffold.ts b/src/utils/scaffold.ts
@@ -63,7 +63,6 @@ function modifyMainTs(pathToMainTs: string) {
   if (!modifiedMainTs.includes(modifiedListen)) {
     recordWarning('Could not set listening port to `process.env.PORT`', 'in file `app.module.ts`. Please adjust manually.');
   } else {
-    recordWarning('Could not set listening port to `process.env.PORT`', 'in file `app.module.ts`. Please adjust manually.');
     fs.writeFileSync(pathToMainTs, modifiedMainTs);
   }
 }