Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug fixes #4

Open
ad6398 opened this issue Nov 17, 2020 · 3 comments
Open

minor bug fixes #4

ad6398 opened this issue Nov 17, 2020 · 3 comments

Comments

@ad6398
Copy link

ad6398 commented Nov 17, 2020

  1. Fair sequence bug
    torch.div(self.indices_buf, vocab_size, out=self.beams_buf) gives error, it should be replaced by torch.floor_divide(self.indices_buf, vocab_size, out=self.beams_buf)

  2. File naming error:
    in data/stage_segmentation notebook file names generated is _sent_trans_cons_label_2.pkl but it is expected as _sent_trans_cons_label.pkl by other part of codes.

  3. Synatx error
    in data/read_labels notebook line 33 has missing : in if condition.

@jiaaoc
Copy link
Member

jiaaoc commented Nov 18, 2020

Thanks for the note, we will push the updated version.

@Ricardokevins
Copy link

Ricardokevins commented May 28, 2021

it's obvious that anthor didn`t fix the bug lol

@manish142000
Copy link

Does this model perform well on Longer Dialogues ? like 8000 - 10000 tokens ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants