Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the timeout period for pixl export-patient-data #396

Open
stefpiatek opened this issue May 3, 2024 · 1 comment
Open

Set the timeout period for pixl export-patient-data #396

stefpiatek opened this issue May 3, 2024 · 1 comment
Milestone

Comments

@stefpiatek
Copy link
Contributor

Definition of Done / Acceptance Criteria

as a pixl pipeline user, I'd like to be able to set the timeout period in minutes for the rest request used in pixl export-patient-data. So that for large exports, it doesn't time out but I get notified of any failures. Default of half an hour might be reasonable.

Testing

No response

Documentation

Update documentation of CLI

Dependencies

No response

Details and Comments

No response

@jeremyestein
Copy link
Contributor

Setting the timeout on the request side is already possible as of #370 , albeit with a lower default of 5 minutes.
I haven't tested this with particularly long-running exports, however. I'm not sure whether the server (or docker) would time us out after a while.
We would probably want to look into whether FastAPI can be configured to send periodic messages to show it's still processing, or better to make it fully asynchronous so we're not dependent on this long-running TCP connection staying up, and then it'd be the CLI's job to query for status every so often. (see also https://fastapi.tiangolo.com/tutorial/background-tasks/ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants