Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish <agent> more as a related entity rather than a piece of descriptive information #58

Closed
18 of 27 tasks
kerstarno opened this issue Jul 24, 2023 · 2 comments
Closed
18 of 27 tasks
Assignees
Labels
Control This issue relates to the control attribute EAC minor revisions This issue is part of the annual minor revisions cycle for EAC-CPF EAC schema This relates to a change in the schema for EAC-CPF EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 EAD Schema (general) This relates to a change in the general schema for EAD ead-archDesc This issue relates to the ead-archDesc module ead-findAidDesc This issue relates to the ead-findAidDesc module (currently still named ead-fileDesc) Implemented in draft version This has been implemented in draft version

Comments

@kerstarno
Copy link

kerstarno commented Jul 24, 2023

Creator of issue

  1. Kerstin Arnold
  2. EAD team lead, TS-EAS
  3. @kerstarno
  4. [email protected]

The issue relates to

  • EAC-CPF schema issue
  • EAC-CPF Tag Library issue
  • EAD schema issue
  • EAD Tag Library issue
  • Schema issue
  • Tag Library issue
  • Suggestions for all schemas
  • Suggestions for all Tag Libraries
  • Other

Wanted change/feature

Note for working on and testing this issue: When the schema changes are done in development branch, please mark the tasks on the highest levels of the list (printed in bold) by ticking the box. When the changes have been tested successfully, please mark the tasks on the lowest level of the list.

  • Add @agentRole as an optional attribute to <agent>
  • Make @agentRole of data type "token"
  • Adapt the content model of <agent> as follows:
    • <agent> cannot include text
    • <agent> includes <agentName> as a required and repeatable sub-element
    • <agent> includes <agentType> and <agentRole> as optional and repeatable sub-elements
    • <agentName>, <agentRole>, and <agentType> all have the same content model by allowing the elements to contain text, by enabling the optional attributes @audience, @id, @target, @languageOfElement, @scriptOfElement, @conventionDeclarationReference, @maintenanceEventReference, @sourceReference, @localType, @localTypeDeclarationReference, @valueURI, @vocabularySource, and @vocabularySourceURI, and by allowing for attributes from any other namespace
    • <agent> includes <relationType> as a optional and repeatable sub-element
    • <agent> allows for the optional sub-elements <date>, <dateRange>, or <dateSet> (choice between these three, not repeatable), <placeName> (repeatable), and <descriptiveNote> (not repeatable)
    • <agent> allows for the optional attributes @audience, @id, @target, @languageOfElement, @scriptOfElement, @conventionDeclarationReference, @maintenanceEventReference, @sourceReference, @localType, @localTypeDeclarationReference, @valueURI, @vocabularySource, and @vocabularySourceURI
    • <agent> allows for attributes from any other namespace
    • <agent> is a required and repeatable sub-element of <agents> (Create a separate section for elements established as entities #68), a required, not repeatable sub-element in <maintenanceEvent> (Align <control> across EAD and EAC-CPF #32) and an optional and repeatable sub-element in <findAidDesc> (Add <findAidDesc> as replacement of <filedesc> #27)

As a result of the above:

  • Remove <origination> from EAD
  • Remove <repository> from EAD
  • Remove <corpname> from EAD
  • Remove <famname> from EAD
  • Remove <name> from EAD
  • Remove <persname> from EAD
@kerstarno kerstarno added EAD Schema (general) This relates to a change in the general schema for EAD Implement This has been decided to be implemented Attributes This issue relates to the attributes module Control This issue relates to the control attribute ead-findAidDesc This issue relates to the ead-findAidDesc module (currently still named ead-fileDesc) EAC schema This relates to a change in the schema for EAC-CPF EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 EAC minor revisions This issue is part of the annual minor revisions cycle for EAC-CPF labels Jul 24, 2023
@kerstarno kerstarno changed the title Add new attribute @agentRole to <agent> Establish <agent> more as a related entity rather than a piece of descriptive information Dec 20, 2023
@kerstarno kerstarno added the ead-archDesc This issue relates to the ead-archDesc module label Dec 20, 2023
@fordmadox fordmadox removed the Implement This has been decided to be implemented label Jan 15, 2024
@kerstarno
Copy link
Author

Tested with the XSD and the RNG. Apart from @localType and @localTypeDeclarationReference currently missing from <agent>, all the above changes are implemented as expected.

I have created a pull request with this change (#84). Once this has been merged and the schemas have been generated anew, this issue will need another quick round of testing.

@kerstarno kerstarno assigned fordmadox and unassigned kerstarno Jan 18, 2024
@kerstarno kerstarno added Tested successfully This is has been tested successfully and is considered done in the development branch Needs more work This has been tested unsuccessfully and needs more work and removed Ready for testing This is ready for testing Attributes This issue relates to the attributes module Tested successfully This is has been tested successfully and is considered done in the development branch labels Jan 18, 2024
@fordmadox fordmadox assigned kerstarno and unassigned fordmadox Jan 18, 2024
@fordmadox fordmadox added Ready for testing This is ready for testing and removed Needs more work This has been tested unsuccessfully and needs more work labels Jan 18, 2024
@kerstarno kerstarno moved this to Ready for testing in Major EAD revision Jan 18, 2024
@kerstarno
Copy link
Author

Re-tested with the XSD and the RNG and can confirm that <agent> now includes @localType and @localTypeDeclarationReference.

@kerstarno kerstarno added Implemented in draft version This has been implemented in draft version and removed Ready for testing This is ready for testing labels Jan 18, 2024
@kerstarno kerstarno moved this from Ready for testing to Merged in Major EAD revision Jan 18, 2024
@github-project-automation github-project-automation bot moved this from Merged to Ready for testing in Major EAD revision Jan 29, 2024
@kerstarno kerstarno moved this from Ready for testing to Merged in Major EAD revision Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Control This issue relates to the control attribute EAC minor revisions This issue is part of the annual minor revisions cycle for EAC-CPF EAC schema This relates to a change in the schema for EAC-CPF EAD major revision (EAD 4.0) This issue is part of the EAD major revision towards EAD 4.0 EAD Schema (general) This relates to a change in the general schema for EAD ead-archDesc This issue relates to the ead-archDesc module ead-findAidDesc This issue relates to the ead-findAidDesc module (currently still named ead-fileDesc) Implemented in draft version This has been implemented in draft version
Projects
Archived in project
Development

No branches or pull requests

3 participants