Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run tests #5

Merged
merged 2 commits into from
Jan 27, 2024
Merged

CI: run tests #5

merged 2 commits into from
Jan 27, 2024

Conversation

tarcieri
Copy link
Member

@stevefan1999-personal
Copy link
Contributor

my two cents: doc workflow should be on done together with a new release workflow, which is triggered when we publish a new git tag (and also push to crates.io altogether)

We can either create the tag ourselves, or we can use the Github's release button to make a tag for us too,

@tarcieri
Copy link
Member Author

We generally run the doc workflow in-band with other tests, where the tests will usually take the longest. Docs are surprisingly easy to break, so it's nice to catch those breakages as part of a PR that's breaking them, instead of a surprise that blocks a release.

@stevefan1999-personal
Copy link
Contributor

We generally run the doc workflow in-band with other tests, where the tests will usually take the longest. Docs are surprisingly easy to break, so it's nice to catch those breakages as part of a PR that's breaking them, instead of a surprise that blocks a release.

Nice catch! However it will definite make the pipeline longer, if the document generation is long. I'm not sure if we would went into a situation where all other stuff are finished but document generation took 5 minutes...Although at this point indeed it seems like something is going on

@tarcieri
Copy link
Member Author

It's currently 1m 12s so I'm not too worried.

The tests take 47s, so aside from runner starvation it would save us ~25s.

@tarcieri tarcieri merged commit 4e0ea22 into master Jan 27, 2024
5 checks passed
@tarcieri tarcieri deleted the ci/run-tests branch January 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants