p521: Use unsaturated limbs #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`U576::words()` returns saturated 64-bit limbs but the field arithmetic for tight points require 59-bit limbs, convert it into a little endian byte array and let `fiat-crypto` deal with the unsaturation. Signed-off-by: Arvind Mukund <[email protected]>
Signed-off-by: Arvind Mukund <[email protected]>
tarcieri
reviewed
Nov 1, 2023
Signed-off-by: Arvind Mukund <[email protected]>
tarcieri
reviewed
Nov 1, 2023
|
|
||
| /// Converts the saturated representation [`U576`] into a 528bit array. Each | ||
| /// word is copied in little-endian. | ||
| pub const fn uint_to_le_bytes_unchecked(w: U576) -> [u8; 66] { |
There was a problem hiding this comment.
We should probably add some const fn serializers upstream in crypto-bigint that could handle this sort of thing, but this is fine for now.
tarcieri
approved these changes
Nov 1, 2023
|
Thanks! Curious if this might make some of the field arithmetic tests that were failing work. |
|
Something else still seems to be amiss: #946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a function to converts the
U576into a little endian byte array in constant time and uses it forfrom_uint_unchecked.Tests: