Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic implementation of prime factors recovery #380

Merged
merged 9 commits into from
Nov 11, 2023
Merged

Deterministic implementation of prime factors recovery #380

merged 9 commits into from
Nov 11, 2023

Commits on Nov 10, 2023

  1. Implementation of prime factors recovery

    @davxy @zheylmun
    davxy authored and zheylmun committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5b03ef5 View commit details
    Browse the repository at this point in the history

  2. initial implementation of prime factors recovery algorithm appears to… 

    … work
    @zheylmun
    zheylmun committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    856999b View commit details
    Browse the repository at this point in the history

  3. clean up unnecessary drop calls, improve a few comments

    @zheylmun
    zheylmun committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d82394b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Apply suggestions from code review 

    Improve code comments and documentation

Co-authored-by: Tony Arcieri <[email protected]>
    @zheylmun @tarcieri
    zheylmun and tarcieri authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3db40ad View commit details
    Browse the repository at this point in the history

  2. Use Zeroizing BigInts for intermediate computations

    @zheylmun
    zheylmun committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7fe9a57 View commit details
    Browse the repository at this point in the history

  3. clean up function constant BigInt use a bit

    @zheylmun
    zheylmun committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9357075 View commit details
    Browse the repository at this point in the history

  4. Remove extra newline per suggestion 

    Co-authored-by: Tony Arcieri <[email protected]>
    @zheylmun @tarcieri
    zheylmun and tarcieri authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    ad0c0c8 View commit details
    Browse the repository at this point in the history

  5. Check public exponent before attempting to recover primes

    @zheylmun
    zheylmun committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    8a259da View commit details
    Browse the repository at this point in the history

  6. Run the validation function if the primes are recovered

    @zheylmun
    zheylmun committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    de60cc3 View commit details
    Browse the repository at this point in the history