Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 decoder #6

Closed
est31 opened this issue Jan 10, 2017 · 12 comments
Closed

MP3 decoder #6

est31 opened this issue Jan 10, 2017 · 12 comments

Comments

@est31
Copy link
Member

est31 commented Jan 10, 2017

Would be cool to have a pure rust MP3 decoder that's permissively licensed. Couldn't find anything on crates.io, so we'd have to write our own.

While there are quite some free software decoders written in C, most of them are copylefted (LGPL or GPL).

These are the only non copyleft implementations I could find:

This is a big list of decoders available (most of them are either non free or copyleft): http://www.mp3-tech.org/programmer/decoding.html

I'd say we should port the haskell decoder to rust. Any volunteers?

@est31
Copy link
Member Author

est31 commented Jan 15, 2017

@Aceeri
Copy link

Aceeri commented Feb 7, 2017

@est31
Copy link
Member Author

est31 commented Sep 19, 2017

It seems that @blanham is interested in creating a decoder as well...

@blanham
Copy link

blanham commented Sep 19, 2017

Oh hi! I started researching an mp3 decoder but didn't get very far due to personal stuff. My long term plan was to have it be a decoder and encoder, and maybe have ID3 decoding built-in (I know there are a few existing ID3 tag libraries, but I think it might make sense to include it with the encoder/decoder) I might be able to dedicate some time to restarting work now, and would definitely be open to adding it to the org. I was going to license it under 2BSD or MIT, so I think that will work well with your goals. I'll see what I can do, and if I haven't made any progress in the next month I can turn the mp3 crate over to RustAudio at the least. I idle on IRC as ChickeNES, feel free to hit me up there, though it might take me a while to respond.

@est31
Copy link
Member Author

est31 commented Sep 19, 2017

@blanham that sounds really great!

I haven't made any progress in the next month I can turn the mp3 crate over to RustAudio

Its a great idea to give us access. Very much appreciated! All of us are doing this in our free time, and I'm taking months to develop a decoder myself, so if its not ready in a month don't give up on it just yet :). I've also sent you an invite to the org.

@est31
Copy link
Member Author

est31 commented Jan 31, 2018

It seems there hasn't been much progress on this issue lately. @blanham how far have you got? @bemeurer has decided to bring new activity behind this. We have created a repo here and there is a tracking issue for future work RustAudio/mp3#1 . If you have anything substantial, can you publish it? We will decide on whose implementation (yours or @Aceeri 's) we are going to base it on. In any case, we'd be glad to get access to the mp3 crate name :). You can do cargo owner --add from the directory of your mp3 decoder repository. Thank you!

@lieff
Copy link

lieff commented Jan 31, 2018

@est31 Now crates.io have such package https://crates.io/crates/minimp3

@blanham
Copy link

blanham commented Feb 8, 2018

Hi everyone, missed the notification emails on this, sorry about that. Let me dig up my old code and see how far along I was, can get back to y'all this weekend. At the very least I'd love to be involved in some way!

@est31
Copy link
Member Author

est31 commented May 30, 2018

@blanham kind reminder, do you have a base to share that we can start work on? Then you will be involved :).

@mainrs
Copy link

mainrs commented Aug 7, 2018

btw, minimp3 looks to be licensed under the Creative Commons Zero license, so it should be compatible 😄

@est31
Copy link
Member Author

est31 commented Aug 7, 2018

@sirwindfield yes, using it as reference and maybe even porting parts of it to Rust is definitely on the radar.

We also have this roadmap issue for the project: RustAudio/mp3#1

@est31
Copy link
Member Author

est31 commented Aug 7, 2018

Closing in favour of RustAudio/mp3#1

@est31 est31 closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants