Made get/set_swap_interval take and return an enum instead of i32 #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you know if code using i32 breaks with this patch? If it doesn't, perfect, but if it does, a simple solution would be to accept |
|
I'm not sure what you mean by "code using i32", but this is a public API change. However, accepting |
|
@icefoxen He most likely meant code that already used the previous version of the api. :) |
kovaxis
pushed a commit
to kovaxis/rust-sdl2
that referenced
this pull request
Oct 12, 2017
Fixed typo in changelog for PR Rust-SDL2#684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple!