Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_coherence_is_core #1494

Open
philberty opened this issue Aug 22, 2022 · 0 comments
Open

rustc_coherence_is_core #1494

philberty opened this issue Aug 22, 2022 · 0 comments
Labels
enhancement
Milestone
Compiler Intrinsi...

Comments

@philberty
Copy link
Member

Just as a heads up rust-lang/rust#94963 changed the way this kind of impls on builtin and foreign types are handled. Libcore now uses #![rustc_coherence_is_core] to allow impls on any builtin type without #[lang = "..."] and other sysroot crates use #[rustc_allow_incoherent_impl] on all impl items for non-local impls.

Originally posted by @bjorn3 in #1086 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Compiler Intrinsics and Builtins
Development

No branches or pull requests
2 participants
@philberty @CohenArthur