Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 JSON Load Failure With Conditionals #11

Open
voidsong-dragonfly opened this issue Jan 9, 2024 · 2 comments
Open

1.20.1 JSON Load Failure With Conditionals #11

voidsong-dragonfly opened this issue Jan 9, 2024 · 2 comments

Comments

@voidsong-dragonfly
Copy link

voidsong-dragonfly commented Jan 9, 2024

External compat mods cannot add conditionals to Create: Liquid Fuel JSON as they do not fit under the category of recipes, and do not properly respect conditionals manually.

I made Engineered Compatibility and was looking to add compat with both Create: Liquid Fuel and Liquid Burner, to allow for either to be used in packs.

However, as the fluids I am seeking to add do not necessarily exist - namely, IP fuels - I get a datapack loading crash if I try to implement conditionals. Attached below is a recipe-less Forge/NeoForge conditional JSON to show the syntax.

{
  "type": "forge:conditional",
  "recipes": [
    {
      "conditions": [
        {
          "type": "forge:mod_loaded",
          "modid": "createliquidfuel"
        },
        {
          "type": "forge:mod_loaded",
          "modid": "immersivepetroleum"
        }
      ],
      "recipe": {RECIPE GOES HERE}
    }
  ]
}
@RuochenFu21
Copy link
Owner

Thanks for the suggestion, although since it's a mod, I do have a temporary solution if you are willing to give up the time, I respect your choice if you don't. What you can do is dynamically load a class to add the recipe manually to one of the classes that have the list of blaze burner fuels.

@voidsong-dragonfly
Copy link
Author

Ah, it's not a mod yet. Thank you for the suggestion, and I may implement it if by the time I get around to turning Engineered Compatibility from a datapack-mod into a proper mod it's not implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants