Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict mode should be enabled in Storybook #3967

Open
jpveooys opened this issue Nov 26, 2024 · 0 comments
Open

Strict mode should be enabled in Storybook #3967

jpveooys opened this issue Nov 26, 2024 · 0 comments
Labels
Package: react-component-library Package/code type Size: Medium Assessed as medium task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors

Comments

@jpveooys
Copy link
Collaborator

jpveooys commented Nov 26, 2024 •
edited
Loading

Strict mode is currently disabled in Storybook:

design-system/packages/react-component-library/.storybook/main.js

Line 61 in 427642b

strictMode: false,

It should be enabled to give some confidence that components work in strict mode.

With strict mode enabled in Storybook, some e2e tests are failing (mainly in the form example stories). Some of these may be a problem with the relevant stories.
@jpveooys jpveooys added Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Package: react-component-library Package/code type Status: Awaiting triage Issues not yet triaged by the Design System cra-template-royalnavy labels Nov 26, 2024
@m7kvqbe1 m7kvqbe1 added Size: Small Assessed as small task and removed Status: Awaiting triage Issues not yet triaged by the Design System cra-template-royalnavy labels Nov 29, 2024
@m7kvqbe1 m7kvqbe1 moved this to Candidates for Ready in Tactical Board Nov 29, 2024
@m7kvqbe1 m7kvqbe1 added Size: Medium Assessed as medium task and removed Size: Small Assessed as small task labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: react-component-library Package/code type Size: Medium Assessed as medium task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
Tactical Board
Status: Candidates for Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m7kvqbe1 @jpveooys