Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): No container button variant #3823

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Conversation

markhigham
Copy link
Collaborator

@markhigham markhigham commented Jun 3, 2024

Related issue

Closes #3822

Overview

Create a new "No container" button variant

Reason

There is a demand from UR for a "no container" (borderless) button variant

Work carried out

  • Create new variant and added to button styles map
  • Added hoverTextDecoration to styles map, allowing us to set to underline for no container buttons
  • Refactor how button styles are generated. Removing unused CSS

Screenshot

See storybook preview

@markhigham markhigham requested a review from m7kvqbe1 as a code owner June 3, 2024 06:29
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
🔨 Latest commit 16ba7bd
🔍 Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/66670c47f223590008ff8690
😎 Deploy Preview https://deploy-preview-3823--storybook-navy-digital-mod-uk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markhigham markhigham force-pushed the feat/no-container-buttons branch from 84f063b to 5b0e805 Compare June 3, 2024 06:39
@m7kvqbe1 m7kvqbe1 changed the title Feat/no container button variant feat(Button): No container button variant Jun 3, 2024
@m7kvqbe1
Copy link
Collaborator

m7kvqbe1 commented Jun 3, 2024

I seem to remember it needing to be flush with the edges of the container - do you have a link to the design mock?

@markhigham markhigham force-pushed the feat/no-container-buttons branch 6 times, most recently from 33b7ed6 to f015bf3 Compare June 6, 2024 08:53
@markhigham markhigham force-pushed the feat/no-container-buttons branch from a420b8c to 16ba7bd Compare June 10, 2024 14:23
Copy link

@markhigham markhigham merged commit a221894 into master Jun 12, 2024
23 checks passed
@markhigham markhigham deleted the feat/no-container-buttons branch June 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no container button variant
2 participants