Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Downshift v7 #3565

Open
jpveooys opened this issue Jan 4, 2023 · 3 comments
Open

Update to Downshift v7 #3565

jpveooys opened this issue Jan 4, 2023 · 3 comments
Assignees
@markhigham
Labels
Package: react-component-library Package/code type Size: Medium Assessed as medium task Status: Stale Issue with no activity for the past 60 days Type: Accessibility Related to accessibility Type: Dependencies Issues that relate to a dependency

Comments

@jpveooys
Copy link
Collaborator

jpveooys commented Jan 4, 2023

Downshift v7 has various changes related to ARIA 1.2: https://github.com/downshift-js/downshift/blob/master/src/hooks/MIGRATION_V7.md

The changes for useSelect are not insignificant (the wrapper itself should act as the toggle button, from what I can see).

This is also needed to fix failures with axe 4.5.
@jpveooys jpveooys added Package: react-component-library Package/code type Type: Accessibility Related to accessibility Type: Dependencies Issues that relate to a dependency Size: Medium Assessed as medium task labels Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Mar 6, 2023
@markhigham markhigham removed the Status: Stale Issue with no activity for the past 60 days label Apr 5, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Jun 10, 2024
@m7kvqbe1 m7kvqbe1 removed the Status: Stale Issue with no activity for the past 60 days label Jun 19, 2024
@markhigham markhigham self-assigned this Jun 25, 2024
@m7kvqbe1 m7kvqbe1 moved this to Ready in Tactical Board Aug 16, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markhigham markhigham

Labels
Package: react-component-library Package/code type Size: Medium Assessed as medium task Status: Stale Issue with no activity for the past 60 days Type: Accessibility Related to accessibility Type: Dependencies Issues that relate to a dependency
Projects
Tactical Board
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markhigham @m7kvqbe1 @jpveooys