Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and consume @royalnavy/design-tokens package #1331

Closed
8 tasks done
m7kvqbe1 opened this issue Aug 11, 2020 · 2 comments · Fixed by #1370
Closed
8 tasks done

Create and consume @royalnavy/design-tokens package #1331

m7kvqbe1 opened this issue Aug 11, 2020 · 2 comments · Fixed by #1370
Assignees
@m7kvqbe1 @hxltrhuxze
Labels
Package: css-framework Package/code type Package: design-tokens Package/code type Type: Enhancement New feature or request
Milestone
Styled-Components...

Comments

@m7kvqbe1
Copy link
Collaborator

m7kvqbe1 commented Aug 11, 2020 •
edited
Loading

@m7kvqbe1 m7kvqbe1 self-assigned this Aug 11, 2020
@m7kvqbe1 m7kvqbe1 added Package: css-framework Package/code type Package: react-component-library Package/code type Type: Enhancement New feature or request Package: design-tokens Package/code type and removed Package: react-component-library Package/code type labels Aug 11, 2020
@m7kvqbe1 m7kvqbe1 mentioned this issue Aug 12, 2020
Closed
@el7h1rw2 el7h1rw2 mentioned this issue Aug 19, 2020
Closed
3 tasks
@m7kvqbe1 m7kvqbe1 removed their assignment Aug 19, 2020
@m7kvqbe1 m7kvqbe1 added this to the Styled-Components Migration milestone Aug 19, 2020
@m7kvqbe1 m7kvqbe1 mentioned this issue Aug 19, 2020
Closed
@m7kvqbe1 m7kvqbe1 self-assigned this Aug 20, 2020
@m7kvqbe1 m7kvqbe1 mentioned this issue Aug 26, 2020
Merged
5 tasks
@m7kvqbe1
Copy link
Collaborator Author

m7kvqbe1 commented Aug 27, 2020 •
edited
Loading

Known issue when css-framework SASS is imported into a downstream project and run through sass-loader.

It can't resolve the design-tokens import.

Working on a fix for this now.

@m7kvqbe1
Copy link
Collaborator Author

Issue appears to be just within CI because of yarn workspaces - it was missing a local build of the design-tokens package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7kvqbe1 m7kvqbe1

@hxltrhuxze hxltrhuxze

Labels
Package: css-framework Package/code type Package: design-tokens Package/code type Type: Enhancement New feature or request
Projects
None yet
Milestone
Styled-Components Migration
Development

Successfully merging a pull request may close this issue.

feat(DesignTokens): Create and consume @royalnavy/design-tokens package Royal-Navy/design-system
2 participants
@m7kvqbe1 @hxltrhuxze