From 0b4c0fc70584f7df1e98343f1fd4c5c0af20061c Mon Sep 17 00:00:00 2001 From: Prashanth684 Date: Thu, 29 Aug 2024 14:39:32 -0700 Subject: [PATCH] OKD: add snippet regarding OKD branding The branding for OKD is different from Openshift and is controlled in some places by go files which have the `//go:build !ocp` directive, but the dockerfile hardcodes ocp. To get around this, the TAGS variable for introduced in some repos to build the OKD variant of code. Document for posterity. --- enhancements/okd-on-fedora-coreos-in-prow.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/enhancements/okd-on-fedora-coreos-in-prow.md b/enhancements/okd-on-fedora-coreos-in-prow.md index c944e39ccc4..381040a9b75 100644 --- a/enhancements/okd-on-fedora-coreos-in-prow.md +++ b/enhancements/okd-on-fedora-coreos-in-prow.md @@ -75,6 +75,13 @@ This is a proposal to: - by encouraging and directing community contributors to send patches and bug fixes directly to the upstream OpenShift codebase - create documentation and share knowledge about OKD +### OKD branding + +The branding for OKD differs from OpenShift, and it is crucial to display the appropriate login page and documentation links. +When building specific components that rely on the OKD variant of code for the correct branding, Dockerfiles must use the `TAGS` +variable and set the value to `scos` when building CentOS Stream-based images and `fcos` when building Fedora CoreOS-based images. +By default, this value is set to `ocp` and is overridden through the CI configuration for building these images. + ### Graduation Criteria - [x] [OKD repository](https://github.com/openshift/okd/) exists for community issue and bug triage, and development tracking.